Skip to content

Commit

Permalink
Exception handling for GetLanguageBranches method
Browse files Browse the repository at this point in the history
  • Loading branch information
patkleef committed Mar 12, 2021
1 parent 32a7fbc commit dd42218
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to this project will be documented in this file.

## [4.0.1]

- Issue #146 - exception handling when something is wrong with the product content

## [4.0.0]

- PR #136 EPiServer.Core.PageNotFoundException on parent content. Credits to [adnanzameerx](https://github.com/adnanzameerx).
Expand Down
22 changes: 21 additions & 1 deletion src/Geta.SEO.Sitemaps/XML/SitemapXmlGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@ protected virtual IEnumerable<CurrentLanguageContent> GetLanguageBranches(Conten
return GetFallbackLanguageBranches(contentLink);
}

return this.ContentRepository.GetLanguageBranches<IContent>(contentLink).Select(x => new CurrentLanguageContent { Content = x, CurrentLanguage = GetCurrentLanguage(x), MasterLanguage = GetMasterLanguage(x) });
if (TryGetLanguageBranches<IContent>(contentLink, out var contentLanguages))
{
return contentLanguages.Select(x => new CurrentLanguageContent { Content = x, CurrentLanguage = GetCurrentLanguage(x), MasterLanguage = GetMasterLanguage(x) });
}
return Enumerable.Empty<CurrentLanguageContent>();
}

protected virtual IEnumerable<CurrentLanguageContent> GetFallbackLanguageBranches(ContentReference contentLink)
Expand Down Expand Up @@ -611,5 +615,21 @@ protected bool TryGet<T>(ContentReference contentLink, out T content, LoaderOpti

return false;
}

protected bool TryGetLanguageBranches<T>(ContentReference contentLink, out IEnumerable<T> content) where T : IContentData
{
content = Enumerable.Empty<T>();
try
{
content = this.ContentRepository.GetLanguageBranches<T>(contentLink);

return true;
}
catch (Exception e)
{
Log.Error("Error getting language branches for contentReference " + contentLink + Environment.NewLine + e);
}
return false;
}
}
}

0 comments on commit dd42218

Please sign in to comment.