-
Notifications
You must be signed in to change notification settings - Fork 43
Add alt text to all docs images #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! Overall, Codex did a pretty good job here. There were a bunch of updates needed, though.
A few other things I found:
- I identified (and noted) a bunch of pages that seem to be extraneous.
- Some of the files (particularly the individual authenticated access guides) seem to have extra backslashes at the end of some paragraphs.
- We also need to update a few of the authenticated access guides with updated screenshots to reflect the rename.
- Should card images have alt text too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is no longer used? Looks like it redirects to https://gitbook.com/docs/collaboration/change-requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is also no longer used, and redirects to https://gitbook.com/docs/collaboration/live-edits
publishing-documentation/authenticated-access/setting-up-okta.md
Outdated
Show resolved
Hide resolved
publishing-documentation/authenticated-access/setting-up-okta.md
Outdated
Show resolved
Hide resolved
@@ -11,7 +11,7 @@ You can customize the appearance of your published documentation, match the user | |||
|
|||
You can apply customizations to your entire docs site as a site-wide theme, or to individual variants and site sections. | |||
|
|||
<figure><img src="../../.gitbook/assets/21_04_25_customization_published_site.svg" alt=""><figcaption><p>GitBook's own documentation is an example of a customized docs site.</p></figcaption></figure> | |||
<figure><img src="../../.gitbook/assets/21_04_25_customization_published_site.svg" alt="A GitBook screenshot showing a customized docs site"><figcaption><p>GitBook's own documentation is an example of a customized docs site.</p></figcaption></figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to update this screenshot to reflect our current docs.
snippets/snippets-beta.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images have broken reference links (and this feature is deprecated anyway)
Co-authored-by: Tal Gluck <[email protected]>
publishing-documentation/authenticated-access/setting-up-auth0.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tal Gluck <[email protected]>
@talagluck Thanks for the review! I’ve committed all your changes and a couple of others that you mentioned needed fixing. I haven’t fixed any of the more in-depth things (like pages that are no longer live or VA images that need replacing) Let me know what you think and if we’re ready to merge! |
@stephen-ashby then I think we should be good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Testing
git status --short
https://chatgpt.com/codex/tasks/task_b_68540b946ffc8326b4701e5271dd6e11