Test overwrite_existing apparent symlink dereferencing
#2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To investigate GitoxideLabs#2006, this explodes the occasionally failing test `writes_through_symlinks_are_prevented_even_if_overwriting_is_allowed` into 1000 identical tests, using `test_case::test_matrix`. When run in series, they all pass, but when run in parallel with `cargo nextest`, some failures always occur, at least when this is done on macOS. This is as predicted in: GitoxideLabs#2006 (comment) A more specific result in local testing on macOS 15 is that, while the number of failures is 0 with `--test-threads=1`, with 2 or more threads, the number of failures tends to *decrease* with the number of threads. The most failures occur with `--test-threads=2`, about 30 on the system tested, while `--test-threads=16` has about 10 failures. The tests were run with this command, with any `--test-threads=<N>` argument added: cargo nextest run -p gix-worktree-state-tests writes_through_symlinks_are_prevented_even_if_overwriting_is_allowed --no-fail-fast
To see if this can sometimes reproduce GitoxideLabs#2006 even outside macOS. The `fail-fast: false` added here can be removed after testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To investigate #2006, this explodes the occasionally failing test
writes_through_symlinks_are_prevented_even_if_overwriting_is_allowedinto 1000 identical tests, usingtest_case::test_matrix.When run in series, they all pass, but when run in parallel with
cargo nextest, some failures always occur, at least when this is done on macOS. This is as predicted in #2006 (comment).A more specific result in local testing on macOS 15 is that, while the number of failures is 0 with
--test-threads=1, with 2 or more threads, the number of failures tends to decrease with the number of threads. The most failures occur with--test-threads=2, about 30 on the system tested, while--test-threads=16has about 10 failures.The tests were run with this command, with any
--test-threads=<N>argument added:See #2006 (comment) for substantial further details, including more up to date information covering reproduction on other platforms--it turns out not to be just macOS--and other relevant information and ideas.
(Maybe this PR can turn into a fix, once the cause is figured out. If not, it could be superseded by the fix and closed.)