Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache to qfRound estimated matching queries #1122

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Add cache to qfRound estimated matching queries #1122

merged 3 commits into from
Sep 11, 2023

Conversation

mohammadranjbarz
Copy link
Collaborator

related to #1103

@CarlosQ96 We needed to to change our query from raw SQL query to typeorm one to can use cache feature

CarlosQ96
CarlosQ96 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mohammed LGTM

Just removed unused code, can merge

@mohammadranjbarz
Copy link
Collaborator Author

Thanks @CarlosQ96
I need to explain this to @maryjaf and she should create some qfRounds before merging this, so after we prepared for testing that, I'll merge it

@mohammadranjbarz mohammadranjbarz merged commit e89a515 into staging Sep 11, 2023
3 checks passed
@mohammadranjbarz mohammadranjbarz deleted the f_1103_cache_qf_related_queries branch September 11, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadranjbarz @CarlosQ96