-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch unlisted projects #1889
Fetch unlisted projects #1889
Conversation
WalkthroughThe changes introduce a new optional parameter Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/repositories/projectRepository.ts (1)
86-86
: Consider adding documentation for the new parameterWhile the implementation is solid, it would be helpful to add JSDoc comments explaining:
- The purpose of the includeUnlisted parameter
- Expected behavior when true/false
- Default behavior when undefined
Example:
+/** + * When true, includes all active projects regardless of review status. + * When false or undefined, only includes active projects with 'Listed' review status. + */ includeUnlisted?: boolean;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/repositories/projectRepository.ts
(3 hunks)src/resolvers/projectResolver.ts
(3 hunks)
🔇 Additional comments (5)
src/repositories/projectRepository.ts (3)
86-86
: LGTM! Clean type definition addition
The new optional boolean parameter is properly typed and follows TypeScript conventions.
101-101
: LGTM! Parameter properly destructured
The new parameter is correctly added to the function's parameter destructuring.
129-136
: LGTM! Secure implementation of the filter logic
The implementation:
- Properly handles the new filter condition
- Uses parameterized queries for security
- Maintains existing review status check when includeUnlisted is false
src/resolvers/projectResolver.ts (2)
271-273
: LGTM! Clean field addition to GetProjectsArgs
The new field is properly decorated and follows the existing pattern in the class.
746-746
: LGTM! Parameter correctly handled in allProjects query
The implementation:
- Properly extracts the parameter from args
- Correctly passes it to filterProjectsQuery
- Maintains existing functionality
Also applies to: 773-773
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;), thx @MohammadPCh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohammadPCh LGTM
Summary by CodeRabbit
New Features
Bug Fixes
Documentation