Fix/Showing cancelled projects

[kkatusic]

• Fix/Showing cancelled projects #5016

Summary by CodeRabbit

• Refactor
  • Improved the project access control logic to ensure consistent and secure validation of ownership when viewing projects in draft or cancelled states.

[coderabbitai]

Walkthrough

The changes update the canUserVisitProject function in the project validator module. The condition for verifying project access has been modified to use project.adminUser.id instead of project.adminUserId. Additionally, a redundant comment explaining the access control logic has been removed. Despite these modifications, the logic ensuring that only the project owner can access projects in drafted or cancelled states remains intact. There are no changes to any exported or public entities.

Changes

File	Summary
src/.../projectValidator.ts	Updated access condition from project.adminUserId to project.adminUser.id and removed a comment

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant V as Validator
    participant P as Project Entity

    U->>V: Request to view project
    V->>P: Retrieve project details (adminUser object)
    P-->>V: Send adminUser with id
    V->>V: Compare userId with adminUser.id
    V-->>U: Return access granted/denied

Loading

Poem

I'm a rabbit with code so fine,
Hopping through logic line by line.
From adminUserId to adminUser.id in sight,
The code now gleams so clear and bright.
With each tweak, I dance in delight!
🐇💻 Hop on, let bugs take flight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54c1683 and e4dcb95.

📒 Files selected for processing (1)

• src/utils/validators/projectValidator.ts (1 hunks)

🔇 Additional comments (2)

src/utils/validators/projectValidator.ts (2)

180-180: LGTM!

The added blank line improves code readability by separating the null check from the main business logic.

---

185-185:

❓ Verification inconclusive

Verify eager loading of adminUser relation.

The change from adminUserId to adminUser.id suggests accessing the ID through a related entity. Ensure that the adminUser relation is properly eager loaded when fetching the project to avoid potential N+1 query performance issues.

Let's verify the Project entity configuration and usage:

---

🏁 Script executed:

#!/bin/bash
# Search for Project entity definition and its relation configurations
ast-grep --pattern 'class Project {
  $$$
  adminUser
  $$$
}'

# Search for places where projects are fetched to verify eager loading
rg -A 5 'from project.*join.*admin_user'

Length of output: 107

---

Verify eager loading of the adminUser relation in Project queries

The change from project.adminUserId to project.adminUser.id indicates that the project’s admin user is now accessed via a related entity instead of a direct property. This requires extra caution: please ensure that the adminUser relation is eagerly loaded or properly joined when projects are fetched. Automated searches did not yield conclusive evidence on whether this relation is eagerly loaded. Kindly verify manually that:

• The Project entity correctly defines the adminUser relation with an eager-loading configuration (or that queries fetching a Project include a join on adminUser).
• All usages of Project data ensure that adminUser is available to prevent runtime errors or potential N+1 query issues.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.