-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GDAL and RichDEM dependancy from tests #675
Conversation
0a36ede
to
f0a24a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review afterwards
@adehecq @rhugonnet I have made some review, please tell if other remarks to be able to merge. The richdem, gdal removal was discussed with @rhugonnet . Have a good day |
7284c9c
to
951e2a9
Compare
Impeccable 👌, I have nothing to comment on. Great work! I'll have a quick look at the SciPy issue. |
951e2a9
to
3686704
Compare
ca232a2
to
9171742
Compare
@duboise-cnes one of your comment does not allow the merging, i don't understand how it works on github x) |
Ah yes 😅. I think it's because when the a reviewer selects "Request changes" when posting the review (as did @duboise-cnes here), they need to re-review with approval later on! |
Sorry, I am not that familiar with github review process. I normally have rectified my mistake now, you can normally merge |
Resolves #671.
Description
The purpose of this PR is to eliminate dependencies on
GDAL
andRichDEM
in thexDEM
tests, thereby simplifying the installation process for developers. The scripts related toGDAL
andRichDEM
have been relocated to the xdem-data repository, where they generate and save the ground truth data in.tif
format. These.tif
files are then imported into xDEM during test execution.Changes
The functions related to
GDAL
andRichDEM
have been removed fromconftest.py
and the test files, and transferred toxdem-data
. These functions have been replaced by calls to the ground truths generated withinxdem-data
.New functions have been added to
conftest.py
and functions inexamples.py
has been modified to retrieve the ground truth data from the xdem-data repository.The
GDAL
andRichDEM
packages have been removed from the configuration files.The Makefile has been simplified and restored for Python versions above 3.10.
The version of the
scipy
package has been fixed to <1.15.0, as the new version causes issues withtest_biascorr.py
. A new issue has been opened to modify this when an update ofscipy
will be released Fixscipy<1.15.0
pin in virtual environment configuration files once issue in SciPy is resolved #677.Note
Before merging:
_TESTDATA_REPO_URL
and_COMMIT_HASH
inexample.py
would have to be updated to point the correct repository