Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe_update_tagblock from cli to suppress decode errors #41

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

pwoods25443
Copy link
Member

Closes #40

Add safe_update_tagblock() and use it from the cli

This will prevent the cli from failing if you pass a malformed tagblock that cannot be decoded. In this case the nmea line is passed to the output with no changes

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #41 (5ad09ad) into dev (7d0a606) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #41      +/-   ##
==========================================
+ Coverage   98.43%   98.45%   +0.01%     
==========================================
  Files          27       28       +1     
  Lines        1469     1484      +15     
==========================================
+ Hits         1446     1461      +15     
  Misses         23       23              
Flag Coverage Δ
unittests 98.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ais_tools/__init__.py 100.00% <100.00%> (ø)
ais_tools/cli.py 94.93% <100.00%> (ø)
ais_tools/tagblock.py 100.00% <100.00%> (ø)
tests/test_edge_cases.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pwoods25443 pwoods25443 self-assigned this Jan 19, 2023
@pwoods25443 pwoods25443 merged commit 85f9ba6 into dev Jan 19, 2023
@pwoods25443 pwoods25443 deleted the issue-40 branch January 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant