Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved checksum #56

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Improved checksum #56

merged 3 commits into from
Apr 3, 2024

Conversation

pwoods25443
Copy link
Member

Copy the improved checksum c code from the tagblock-c branch

This helps with

  • Better buffer overrun protection
  • Better module layout for c code
  • Fix error reported on exit about bad refcount, caused by improper handling of return values from is_checksum_valid

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (a02fda6) to head (73411d9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #56   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          32       32           
  Lines        1720     1720           
=======================================
  Hits         1697     1697           
  Misses         23       23           
Flag Coverage Δ
unittests 98.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pwoods25443 pwoods25443 merged commit 8acaa48 into dev Apr 3, 2024
12 checks passed
@pwoods25443 pwoods25443 deleted the better-checksum branch April 3, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant