Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement in normalize_dedup_key() #63

Merged
merged 1 commit into from
May 24, 2024

Conversation

pwoods25443
Copy link
Member

Improve performance of normalize_dedup_key() by ~3x by

  • Use a pre-compiled regex
  • Use xxhash instead of hashlib to compute the hash

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (d834a28) to head (45aca56).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #63      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files          33       33              
  Lines        1750     1748       -2     
==========================================
- Hits         1727     1725       -2     
  Misses         23       23              
Flag Coverage Δ
unittests 98.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pwoods25443 pwoods25443 merged commit d8866be into dev May 24, 2024
12 checks passed
@pwoods25443 pwoods25443 deleted the dedup-key-performance branch May 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant