Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gnc-plugin-page-register.c] add Desc substring filter #1873

Draft
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

christopherlam
Copy link
Contributor

@christopherlam christopherlam commented Feb 22, 2024

Very buggy: Desc substring filter in register

Desc filter needs to be string-sanitized or encoded before saving into state file

For discussion

image

@christopherlam christopherlam force-pushed the register-desc-filter branch 3 times, most recently from 2af48ed to 71a8ed0 Compare February 26, 2024 13:06
@christopherlam
Copy link
Contributor Author

christopherlam commented Feb 26, 2024

I think this is ready for beta testing. It works well, saves and retrieves in .gcm; and the desc_filter is stored as a GString because a std::string was too difficult with the struct in struct.

@jralls
Copy link
Member

jralls commented Feb 26, 2024

How is this a UX improvement over Find?

@christopherlam
Copy link
Contributor Author

How is this a UX improvement over Find?

I occasionally temporarily want to work on all transactions with the same Description, and the single-split account register is tidier than the multi-split Find window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants