Mudlet GMCP Discord Rich Presence functionality #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added party information - Added area description - Fixed config file issues
- Added "help discord" under the Integration area - Added"discord" user command to set the values to display in Discord Rich Prescense - Added player name and level as options to show - Party now shows even if you are the only one in it - Defaults to config file and/or code defaults if a player disables certain values
Volte6
requested changes
May 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Mudlet’s GMCP support by adding Discord Rich Presence functionality and improving helpfile consistency.
- Updated help templates for Mudlet UI, Map, and Client commands with standardized color formatting
- Added a new helpfile for Discord integration and updated keywords
- Replaced the legacy mudlet-config.yaml with an updated config.yaml that now includes Discord Rich Presence settings
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/gmcp/files/datafiles/templates/help/mudletui.template | Updated notes section formatting for consistency |
| modules/gmcp/files/datafiles/templates/help/mudletmap.template | Updated notes section formatting for consistency |
| modules/gmcp/files/datafiles/templates/help/discord.template | New helpfile added for Discord integration |
| modules/gmcp/files/datafiles/templates/help/client.template & checkclient.template | Minor text formatting improvements |
| modules/gmcp/files/data-overlays/mudlet-config.yaml | Removed legacy configuration file |
| modules/gmcp/files/data-overlays/keywords.yaml | Added "integration: discord" keyword |
| modules/gmcp/files/data-overlays/config.yaml | New configuration file including Discord Rich Presence settings |
Fixed: - We are now using the comma ok idiom everywhere - No more default config values in code, just relying on the config file. Changed: - Reworked how GMCP messages are sent out, to remove some redundant code - Finished support for External.Discord.Get and External.Discord.Hello messages from client and corresponding messages from the server - Did a general cleanup and optimization of a few things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability for the game to send Rich Presence information to Discord.
This will also add a better Discord integration directly in Mudlet:
By default it sends the following information:
As well as player name, level, area, party information and connection time.
The game name used in Discord comes from the application id or if not sent, the game name in config.yaml
Added "discord" user command to enable or disable certain information:
Everything is saved on the player, and kept across sessions.
Added helpfile in the Integration category. Here we have potential for other integrations to be placed.
This gmcp information could potentially be used by the web-client as well, to send information to Discord if activated.
I snuck in some beautification and alignment on the other helpfiles for gmcp and Mudlet - that is why they are also in this PR.