Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing and accidentally reset OpenXRPose.gdns parameters used in the right hand mesh #235

Conversation

goatchurchprime
Copy link

This is intended to fix #234

It also sorts out the two instances of gdns parameter accessing which prevent using these nodes in an app on the PC without loading VR, which is sometimes a better place to develop and debug features you don't need to be in a headset to test.

@goatchurchprime
Copy link
Author

Turns out this is not good enough, because when it sets the OpenXRSkeleton::hand = 1 it is too late because it has already tried and failed to find all the bones (which are ending in '_R' not '_L').

I tried inserting a line:

$HandModel/Armature/Skeleton.request_ready()
but it didn't work. (Does it fail with GDNS files?)

The quick work around is the following script on the node vr_glove_right_slim:

extends MeshInstance

func _ready():
	get_parent().hand = 1

as this gets called before the OpenXRSkeleton::_ready() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden gdns parameters can be lost and cause impossible to fix bugs such as two left hands
1 participant