Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Shorten runAdAuction flow if there are no interest groups. #934

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jan 30, 2025

Description

This PR aims to shorten the runAdAuction flow if there are no interest groups in interactive mode.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run build:ext.
  • Now go to example.com, open the DevTools and navigate to the PSAT.
  • Switch to interactive mode.
  • Now directly go to a publisher circle, you can see that runAdAuction won't proceed to loadInterestGroup and directly show showWinningAd box.

Additional Information:

Information to read for reference

Screenshot/Screencast

Screen.Recording.2025-01-30.at.16.32.17.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 self-assigned this Jan 30, 2025
@amovar18 amovar18 added this to the v0.13.0 milestone Jan 30, 2025
@amovar18 amovar18 marked this pull request as ready for review February 3, 2025 08:23
@mohdsayed
Copy link
Collaborator

@amovar18 Please resolve conflicts.

@amovar18
Copy link
Collaborator Author

amovar18 commented Feb 3, 2025

Conflicts have been resolved.
cc @mohdsayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

2 participants