Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Explorable explanation bugs and minor issues #939

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Feb 3, 2025

Description

This PR aims to fix EE bugs and issues that were found in the QA of Explorable Explanations.

Relevant Technical Choices

Testing Instructions

Additional Information:

The following is a checklist of the errors fixed in this PR:

  • Fix error “The devicemotion events are blocked by permissions' policy”.
  • Fix warning “Permissions policy violation: accelerometer is not allowed in this document.”
  • In “Interactive Mode”, when the user hovers over the info icon, the cursor doesn’t change to pointer.
  • Arrows are becoming darker in interactive mode (happens in interactive mode where arrows are drawn on one another).
  • Checkboxes in the top bar do not align well when using small screen size.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 self-assigned this Feb 3, 2025
@amovar18 amovar18 marked this pull request as ready for review February 3, 2025 11:39
@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 3, 2025
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mentioned issued are fixed. Thanks

@mohdsayed mohdsayed merged commit 90ef8ce into develop Feb 3, 2025
6 checks passed
@mohdsayed mohdsayed deleted the fix/ee-bugs branch February 3, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants