Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA:EE: Add info icon to branches in publisher flow #970

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Feb 24, 2025

Description

This PR adds info icon to branches (see screenshot below) in protected audience explorable explanation publisher flow and adds info details for each branch.

Relevant Technical Choices

  • Create a new Info component.
  • Reuse this new Info component in Box as well as Branches component.
  • Add info details for branches.

Testing Instructions

  • Start protected audience explorable explanation.
  • Go to the publisher flow and check if info is added to the branches as seen in the screenshot.
  • Click on each on those i icon to see if they show details.
  • Try with multi-seller too.

Additional Information:

Screenshot/Screencast

image


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 24, 2025
@mohdsayed mohdsayed marked this pull request as ready for review February 24, 2025 17:16
@mohdsayed mohdsayed self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant