Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Dialogflow #76

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Dialogflow #76

wants to merge 15 commits into from

Conversation

yaraki
Copy link
Contributor

@yaraki yaraki commented Aug 24, 2018

No description provided.

yaraki and others added 13 commits September 7, 2017 11:13
@yaraki
Add a sample for Cloud Conversation Engine
0c939df 
Change-Id: I70f12c88bdd820ea510beadb3f8dbb98a9df789e
Merge commit '907990cf19c7b61d73ec272586b3f71909b6e15d' into HEAD
84863f5
Merge commit '2f62a0093794d53368084c1d29871e0e1aa81e53' into HEAD
d4e86eb
Merge commit '3d7dd8c2d245426751fd621d45fb0feb8fefd5bd' into HEAD
589a740
Merge commit '33e7428d458b2f8aa31374973e9dd8bc01c79fca' into HEAD
41a4991
@yaraki
Rename to Dialogflow
fb1ec82 
Bug: 65732552
Change-Id: I1e4ab601548f0254cb0799128e453602020fcde4
@yaraki
Dialogflow: Upgrade to v2beta1
af75592 
This also bumps up other dependencies.

Bug: 65732552
Change-Id: I3bff1a51f5b78a1f84a29ad3e230b6839710f142
Merge commit 'effe37d9d8abbb27322d91fcb97e94d1e168123c' into HEAD
35afe5f
Merge commit '1027e01b5dd2cd47a52d86a939ef97a1593dc155' into HEAD
f8cf628
@yaraki
Merge "Dialogflow: Upgrade to v2beta1"
6c364c5
@yaraki
Fix several issues
f6f63b8 
Speech bubbles had incorrect paddings on older devices.

Prevent audio indicator from covering speech feedback.

Bug: 65732552
Change-Id: Id0839be59e7b92c919913949eb4fa97cf8730eed
@yaraki
Update dependencies
9fff72d 
Bug: 112809915
Change-Id: I1ba68f651373ae9ce079695dd9c81825cd443254
@yaraki
Merge remote-tracking branch 'internal/master'
8659ca2
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@yaraki yaraki requested a review from frankyn August 27, 2018 00:17
@yaraki
Copy link
Contributor Author

yaraki commented Aug 27, 2018

See bug: 112809915 for the context.

lesv
lesv reviewed Aug 27, 2018
View reviewed changes
dialogflow/Dialogflow/README.md

### Set Up to Authenticate With Your Project's Credentials

This Android app uses JSON credential file locally stored in the resources. ***You should not do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - Good advice, we really should demo that.

@theacodes FYI - in case you have an objection to this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really bad from a security standpoint. I would suggest finding a different route.

lesv
lesv reviewed Aug 27, 2018
View reviewed changes
dialogflow/Dialogflow/app/build.gradle
@@ -0,0 +1,118 @@
/*
* Copyright 2017 Google Inc. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think we do All Rights Reserved anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do instead? I copied this from other Cloud samples a few years ago.

lesv
lesv reviewed Aug 27, 2018
View reviewed changes
dialogflow/Dialogflow/app/.gitignore
@@ -0,0 +1 @@
/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if there was only one of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the project is created by Android Studio.

lesv
lesv suggested changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have someone on the ML team review first.

@frankyn frankyn removed their request for review August 27, 2018 16:13
@yaraki
Copy link
Contributor Author

yaraki commented Sep 10, 2018

This was already reviewed by the ML team internally on Gerrit.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theacodes theacodes theacodes left review comments

@lesv lesv lesv requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaraki @googlebot @theacodes @lesv