Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit disable (unsafe) X-XSS-Protection-header #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolaiSoeborg
Copy link

@NicolaiSoeborg NicolaiSoeborg commented Jul 6, 2023

A bit counter-intuitive, but X-XSS-Protection is actually dangerous on (old) browsers supporting the spec.

In filtering mode it easily allows attackers to remove critical blocks of JavaScript, which can introduce vulnerabilities in otherwise safe code: PoC.

In blocking mode it can be used as an side-channel oracle, leaking cross origin bodies/tokens: theory / PoC

Hot take, this is a terrible header that shouldn't be included. In this PR I explicit disable it, but this PR could also easily be refactored to completely remove the header.

Disabling it on modern browsers does nothing, as it is already disabled.

@google-cla
Copy link

google-cla bot commented Jul 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant