Replace URI decode with CGI unescape (#497)

GoogleCloudPlatform · Jan 3, 2023 · 7c3ba75 · 7c3ba75
1 parent 11c1413
commit 7c3ba75
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/test/plugin/base_test.rb b/test/plugin/base_test.rb
@@ -21,6 +21,7 @@
 require 'mocha/test_unit'
 require 'prometheus/client'
 require 'webmock/test_unit'
+require 'cgi'
 
 require_relative 'asserts'
 require_relative 'constants'
@@ -823,7 +824,7 @@ def test_reject_non_utf8_container_name_with_require_valid_tags_true
       params = CONTAINER_FROM_METADATA_PARAMS.merge(
         labels: CONTAINER_FROM_METADATA_PARAMS[:labels].merge(
           "#{GKE_CONSTANTS[:service]}/container_name" =>
-            URI.decode(encoded_name)),
+            CGI.unescape(encoded_name)),
         log_name: encoded_name)
       verify_log_entries(0, params, 'textPayload')
     end
@@ -906,7 +907,7 @@ def test_sanitize_tags_from_container_name_with_require_valid_tags_false
       params = CONTAINER_FROM_METADATA_PARAMS.merge(
         resource: CONTAINER_FROM_METADATA_PARAMS[:resource].merge(
           labels: CONTAINER_FROM_METADATA_PARAMS[:resource][:labels].merge(
-            'container_name' => URI.decode(encoded_container_name))),
+            'container_name' => CGI.unescape(encoded_container_name))),
         log_name: encoded_container_name)
       verify_log_entries(1, params, 'textPayload')
     end