chore(gemspec): update fluentd >= 1.14.x #475
Conversation
|
We'd need to carefully measure the performance of these gem version upgrades. The last attempt to upgrade json gem caused a memory regression and we had to roll it back. We do know that json 2.4.1 is not safe to upgrade to. They do have a newer version 2.5.1 out though. |
|
Hi @qingling128 , what version of ruby are you using in your testing environment? Also what version of jemalloc are you using? There are multiple issues with using later than jemalloc v3.6.0 with libmalloc and ruby will cause memory to continue grow (memory leaks) on fluentd. This curious as the above may not be due to actual json gem upgrade but your environment/configuration/docker could also be a factor in the memory regression. |
Cryptophobia
force-pushed
the
master
branch
from
df03f59 to
ec0e6fd
Compare
|
I pushed json 2.5.1 here for testing. |
- increment gem version for plugin - update to allow fluentd v1.12.3 gem - update json to 2.4.1 for [CVE-2020-10663](https://www.ruby-lang.org/en/news/2020/03/19/json-dos-cve-2020-10663/) Signed-off-by: Anton Ouzounov <[email protected]>
- update to allow fluentd 1.13.3 gem Fluentd changelog for [v1.13.2](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1132) Fluentd changelog for [v1.13.3](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1133) Signed-off-by: Anton Ouzounov <[email protected]>
|
This has been rebased with latest from upstream/master and works with ruby 2.7.4 now. Please test. Test seem to fail with ruby 2.4 now. |
- update fluentd to 1.14.x gem - update json gem to 2.5.1 - fix deprecation warnings during rake tests: `common.rb:114: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open` Fluentd changelog for [v1.14.x](https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#v1140) Signed-off-by: Anton Ouzounov <[email protected]>
common.rb:114: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#openFluentd changelog for v1.14.x
Signed-off-by: Anton Ouzounov [email protected]