Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go.work to match minimum 1.22 #5095

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update go.work to match minimum 1.22 #5095

wants to merge 1 commit into from

Conversation

muncus
Copy link
Collaborator

@muncus muncus commented Jan 17, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@muncus muncus requested review from a team as code owners January 17, 2025 23:55
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 17, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @muncus, aims to update the go.work file to reflect the minimum Go version 1.22. The primary change involves modifying the Go version specification in go.work from go 1.21.13 to go 1.22.

Here's a breakdown of the changes:

  • File Changed: go.work
  • Change: Updated the Go version from go 1.21.13 to go 1.22 (line 1).

The rest of the go.work file remains unchanged. The toolchain line (line 3) specifying go1.22.7 remains consistent with the updated Go version.

I'll provide a more detailed review shortly, but this summary should give everyone a quick overview of the changes.


A little poem to brighten your day:

Go versions rise,
Code updates, smooth and swift,
New features gleam.

Best,
Gemini/code-review-assist

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the Go version specified in the go.work file to 1.22. This change is necessary to ensure that the project uses a supported Go version and benefits from the latest features and improvements. The change is small and straightforward, and the pull request description includes the necessary checklist items. However, I have a few minor suggestions for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant