Skip to content

Commit

Permalink
Chore: Enable unit test ci with skipping flag (#78)
Browse files Browse the repository at this point in the history
* chore: update unit test ci

* fix: fix ci error

* fix: ci error

* chore: update ci

* del: dist/session

Revert "del: dist/session"

This reverts commit b5b3754.

* fix: go test error

* fix: add blank import
  • Loading branch information
Okabe-Junya authored Feb 26, 2025
1 parent 2c01cc9 commit 7cacf1a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/pr-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,15 @@ jobs:
# echo "" > ./dist/index.html
# make coverage-go

# For now, we skip the cloud logging test
# TODO: Remove the flag after the cloud logging test is ready
- name: Backend Test
run: |
mkdir -p dist/session
# A placeholder frontend code read from backend test
echo '<!--INJECT GENERATED CODE HERE FROM BACKEND-->' > ./dist/index.html
go test ./... -args -skip-cloud-logging=true
- name: Backend Format and Lint Check
run: |
make check-format-go
Expand Down
2 changes: 2 additions & 0 deletions pkg/document/generator/generator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (
"testing"

"github.com/google/go-cmp/cmp"

_ "github.com/GoogleCloudPlatform/khi/internal/testflags"
)

func TestGenerateDocumentString(t *testing.T) {
Expand Down
2 changes: 2 additions & 0 deletions pkg/inspection/task/label/query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (

"github.com/GoogleCloudPlatform/khi/pkg/model/enum"
"github.com/GoogleCloudPlatform/khi/pkg/task"

_ "github.com/GoogleCloudPlatform/khi/internal/testflags"
)

func TestQueryTaskLabelOpt(t *testing.T) {
Expand Down

0 comments on commit 7cacf1a

Please sign in to comment.