-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(parametermanager): Added samples for create, get, list and render regional parameter & parameter version #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
durgesh-ninave-crest
wants to merge
7
commits into
GoogleCloudPlatform:main
Choose a base branch
from
durgesh-ninave-crest:parametermanager-regional-samples-create-list-render
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
376e199
feat(parametermanager): Added samples for create, get, list and rende…
durgesh-ninave-crest 27e439a
Merge branch 'main' into parametermanager-regional-samples-create-lis…
durgesh-ninave-crest cef7797
fix(parametermanager): update code samples and testcases for paramete…
durgesh-ninave-crest 6f70d1a
Merge branch 'main' into parametermanager-regional-samples-create-lis…
glasnt 232099c
fix(parametermanager): update testcases and function arguments
durgesh-ninave-crest 190fe09
fix(parametermanager): fix lint issue
durgesh-ninave-crest d35505a
fix(parametermanager): update testcase
durgesh-ninave-crest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"name": "nodejs-parameter-manager-samples", | ||
"private": true, | ||
"license": "Apache-2.0", | ||
"files": [ | ||
"*.js" | ||
], | ||
"author": "Google LLC", | ||
"repository": "googleapis/nodejs-parameter-manager", | ||
"engines": { | ||
"node": ">=20" | ||
}, | ||
"scripts": { | ||
"test": "c8 mocha --recursive test/ --timeout=800000" | ||
}, | ||
"directories": { | ||
"test": "test" | ||
}, | ||
"dependencies": { | ||
"@google-cloud/parametermanager": "^0.1.0" | ||
}, | ||
"devDependencies": { | ||
"@google-cloud/secret-manager": "^5.6.0", | ||
"c8": "^10.1.3", | ||
"chai": "^4.5.0", | ||
"mocha": "^11.1.0", | ||
"uuid": "^11.0.5" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright 2025 Google LLC | ||
glasnt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
'use strict'; | ||
|
||
/** | ||
* Creates a new version of an existing parameter in the specified region | ||
* of the specified project using the Google Cloud Parameter Manager SDK. | ||
* The payload is specified as a JSON string and includes a reference to a secret. | ||
* | ||
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created. | ||
* @param {string} locationId - The ID of the region where parameter is to be created. | ||
* @param {string} parameterId - The ID of the parameter to create. This ID must be unique within the project location. | ||
*/ | ||
async function main(projectId, locationId, parameterId) { | ||
// [START parametermanager_create_regional_param] | ||
/** | ||
* TODO(developer): Uncomment these variables before running the sample. | ||
*/ | ||
// const projectId = 'YOUR_PROJECT_ID'; | ||
// const locationId = 'YOUR_LOCATION_ID'; | ||
// const parameterId = 'YOUR_PARAMETER_ID'; | ||
|
||
// Imports the Parameter Manager library | ||
const {ParameterManagerClient} = require('@google-cloud/parametermanager'); | ||
|
||
// Adding the endpoint to call the regional parameter manager server | ||
const options = { | ||
apiEndpoint: `parametermanager.${locationId}.rep.googleapis.com`, | ||
}; | ||
|
||
// Instantiates a client with regional endpoint | ||
const client = new ParameterManagerClient(options); | ||
|
||
async function createRegionalParam() { | ||
const parent = client.locationPath(projectId, locationId); | ||
const request = { | ||
parent: parent, | ||
parameterId: parameterId, | ||
}; | ||
|
||
const [parameter] = await client.createParameter(request); | ||
console.log(`Created regional parameter: ${parameter.name}`); | ||
return parameter; | ||
} | ||
|
||
return await createRegionalParam(); | ||
// [END parametermanager_create_regional_param] | ||
} | ||
module.exports.main = main; | ||
|
||
/* c8 ignore next 10 */ | ||
if (require.main === module) { | ||
main(...process.argv.slice(2)).catch(err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
process.on('unhandledRejection', err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
} |
95 changes: 95 additions & 0 deletions
95
parametermanager/regional_samples/createRegionalParamVersion.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
// Copyright 2025 Google LLC | ||
glasnt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
'use strict'; | ||
|
||
/** | ||
* Creates a new version of an existing parameter in the specified region | ||
* of the specified project using the Google Cloud Parameter Manager SDK. | ||
* The payload is specified as an unformatted string. | ||
* | ||
* @param {string} projectId - The Google Cloud project ID where the parameter is located. | ||
* @param {string} locationId - The ID of the region where parameter is located. | ||
* @param {string} parameterId - The ID of the parameter for which the version is to be created. | ||
* @param {string} parameterVersionId - The ID of the parameter version to be created. | ||
* @param {string} payload - The unformatted string payload to be stored in the parameter version. | ||
*/ | ||
async function main( | ||
projectId, | ||
locationId, | ||
parameterId, | ||
parameterVersionId, | ||
payload | ||
) { | ||
// [START parametermanager_create_regional_param_version] | ||
/** | ||
* TODO(developer): Uncomment these variables before running the sample. | ||
*/ | ||
// const projectId = 'YOUR_PROJECT_ID'; | ||
// const locationId = 'us-central1'; | ||
// const parameterId = 'YOUR_PARAMETER_ID'; | ||
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID'; | ||
// const payload = 'This is unstructured data'; | ||
|
||
// Imports the Parameter Manager library | ||
const {ParameterManagerClient} = require('@google-cloud/parametermanager'); | ||
|
||
// Adding the endpoint to call the regional parameter manager server | ||
const options = { | ||
apiEndpoint: `parametermanager.${locationId}.rep.googleapis.com`, | ||
}; | ||
|
||
// Instantiates a client with regional endpoint | ||
const client = new ParameterManagerClient(options); | ||
|
||
async function createRegionalParamVersion() { | ||
// Construct the parent resource name | ||
const parent = client.parameterPath(projectId, locationId, parameterId); | ||
|
||
// Construct the parameter version | ||
const parameterVersion = { | ||
payload: { | ||
data: Buffer.from(payload, 'utf8'), | ||
}, | ||
}; | ||
|
||
// Construct the request | ||
const request = { | ||
parent: parent, | ||
parameterVersionId: parameterVersionId, | ||
parameterVersion: parameterVersion, | ||
}; | ||
|
||
// Create the parameter version | ||
const [paramVersion] = await client.createParameterVersion(request); | ||
console.log(`Created regional parameter version: ${paramVersion.name}`); | ||
return paramVersion; | ||
} | ||
|
||
return await createRegionalParamVersion(); | ||
// [END parametermanager_create_regional_param_version] | ||
} | ||
module.exports.main = main; | ||
|
||
/* c8 ignore next 10 */ | ||
if (require.main === module) { | ||
main(...process.argv.slice(2)).catch(err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
process.on('unhandledRejection', err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
} |
103 changes: 103 additions & 0 deletions
103
parametermanager/regional_samples/createRegionalParamVersionWithSecret.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
// Copyright 2025 Google LLC | ||
glasnt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
'use strict'; | ||
|
||
/** | ||
* Creates a new version of an existing parameter in the specified region | ||
* of the specified project using the Google Cloud Parameter Manager SDK. | ||
* The payload is specified as a JSON string and includes a reference to a secret. | ||
* | ||
* @param {string} projectId - The Google Cloud project ID where the parameter is located. | ||
* @param {string} locationId - The ID of the region where parameter is located. | ||
* @param {string} parameterId - The ID of the parameter for which the version is to be created. | ||
* @param {string} parameterVersionId - The ID of the parameter version to be created. | ||
* @param {string} secretId - The ID of the secret to be referenced. | ||
*/ | ||
async function main( | ||
projectId, | ||
locationId, | ||
parameterId, | ||
parameterVersionId, | ||
secretId | ||
) { | ||
// [START parametermanager_create_regional_param_version_with_secret] | ||
/** | ||
* TODO(developer): Uncomment these variables before running the sample. | ||
*/ | ||
// const projectId = 'YOUR_PROJECT_ID'; | ||
// const locationId = 'us-central1'; | ||
// const parameterId = 'YOUR_PARAMETER_ID'; | ||
// const parameterVersionId = 'YOUR_PARAMETER_VERSION_ID'; | ||
// const secretId = 'YOUR_SECRET_ID'; // For example projects/my-project/secrets/application-secret/version/latest | ||
|
||
// Imports the Parameter Manager library | ||
const {ParameterManagerClient} = require('@google-cloud/parametermanager'); | ||
|
||
// Adding the endpoint to call the regional parameter manager server | ||
const options = { | ||
apiEndpoint: `parametermanager.${locationId}.rep.googleapis.com`, | ||
}; | ||
|
||
// Instantiates a client with regional endpoint | ||
const client = new ParameterManagerClient(options); | ||
|
||
async function createRegionalParamVersionWithSecret() { | ||
// Construct the parent resource name | ||
const parent = client.parameterPath(projectId, locationId, parameterId); | ||
|
||
// Construct the payload JSON data with secret references | ||
const payloadData = { | ||
db_user: 'test_user', | ||
db_password: `__REF__("//secretmanager.googleapis.com/${secretId}")`, | ||
Comment on lines
+62
to
+63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this an example of a payload, or does the object keys have to be these values? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is an example of a payload. |
||
}; | ||
|
||
// Construct the parameter version | ||
const parameterVersion = { | ||
payload: { | ||
data: Buffer.from(JSON.stringify(payloadData), 'utf8'), | ||
}, | ||
}; | ||
|
||
// Construct the request | ||
const request = { | ||
parent: parent, | ||
parameterVersionId: parameterVersionId, | ||
parameterVersion: parameterVersion, | ||
}; | ||
|
||
// Create the regional parameter version | ||
const [paramVersion] = await client.createParameterVersion(request); | ||
console.log( | ||
`Created regional parameter version with secret: ${paramVersion.name}` | ||
); | ||
return paramVersion; | ||
} | ||
|
||
return await createRegionalParamVersionWithSecret(); | ||
// [END parametermanager_create_regional_param_version_with_secret] | ||
} | ||
module.exports.main = main; | ||
|
||
/* c8 ignore next 10 */ | ||
if (require.main === module) { | ||
main(...process.argv.slice(2)).catch(err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
process.on('unhandledRejection', err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
} |
80 changes: 80 additions & 0 deletions
80
parametermanager/regional_samples/createStructuredRegionalParam.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
// Copyright 2025 Google LLC | ||
glasnt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// https://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
'use strict'; | ||
|
||
/** | ||
* Creates a parameter in the specified region of the specified project using the Google Cloud Parameter Manager SDK. | ||
* The parameter is created with the specified format type. | ||
* | ||
* @param {string} projectId - The Google Cloud project ID where the parameter is to be created. | ||
* @param {string} locationId - The ID of the region where parameter is to be created. | ||
* @param {string} parameterId - The ID of the parameter to create. | ||
* @param {string} formatType - The format type of the parameter (UNFORMATTED, YAML, JSON). | ||
*/ | ||
async function main(projectId, locationId, parameterId, formatType) { | ||
// [START parametermanager_create_structured_regional_param] | ||
/** | ||
* TODO(developer): Uncomment these variables before running the sample. | ||
*/ | ||
// const {protos} = require('@google-cloud/parametermanager'); | ||
// const projectId = 'YOUR_PROJECT_ID'; | ||
// const locationId = 'YOUR_LOCATION_ID'; | ||
// const parameterId = 'YOUR_PARAMETER_ID'; | ||
// const formatType = protos.google.cloud.parametermanager.v1.ParameterFormat.JSON; | ||
|
||
// Imports the Parameter Manager library | ||
const {ParameterManagerClient} = require('@google-cloud/parametermanager'); | ||
|
||
// Adding the endpoint to call the regional parameter manager server | ||
const options = { | ||
apiEndpoint: `parametermanager.${locationId}.rep.googleapis.com`, | ||
}; | ||
|
||
// Instantiates a client with regional endpoint | ||
const client = new ParameterManagerClient(options); | ||
|
||
async function createStructuredRegionalParam() { | ||
const parent = client.locationPath(projectId, locationId); | ||
const request = { | ||
parent: parent, | ||
parameterId: parameterId, | ||
parameter: { | ||
format: formatType, | ||
}, | ||
}; | ||
|
||
const [parameter] = await client.createParameter(request); | ||
console.log( | ||
`Created regional parameter ${parameter.name} with format ${parameter.format}` | ||
); | ||
return parameter; | ||
} | ||
|
||
return await createStructuredRegionalParam(); | ||
// [END parametermanager_create_structured_regional_param] | ||
} | ||
module.exports.main = main; | ||
|
||
/* c8 ignore next 10 */ | ||
if (require.main === module) { | ||
main(...process.argv.slice(2)).catch(err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
process.on('unhandledRejection', err => { | ||
console.error(err.message); | ||
process.exitCode = 1; | ||
}); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json should sit in the same folder as the samples themselves, otherwise CI will not run successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this package won't run tests correctly, and will conflict with 4068, and that PR came first, this PR will have to be rebased once that one is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for #4068 to be merged and then rebase this PR accordingly to avoid conflicts and ensure the tests run correctly.