Add PTZ support for flipping the canvas #2394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
Mar 8, 2025
editor/src/messages/portfolio/document/navigation/navigation_message_handler.rs
Outdated
Show resolved
Hide resolved
0HyperCube
approved these changes
Mar 9, 2025
There was a problem hiding this comment.
Thanks for your patience with this. It appears to work well and the code looks good.
I'll leave it to @Keavon if they wish to QA test as well. Also we probably need to think about the widget design for this.
|
|
I'll try to work on the UI within the next couple of days. The feature looks like it's all working now, although I'll do more extensive testing when I'm adding the UI change. |
Keavon
force-pushed
the
master
branch
4 times, most recently
from
aa7ff13 to
e11b57a
Compare
Keavon
approved these changes
May 18, 2025
|
All done! Sorry this took a while to tend to. |
|
@Sidharth-Singh10 just a reminder to please comment with this PR number in its issue, #1722, so I can assign that to you for the credit! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1722