Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: verify-azure-function-with-packages #383 #393

Merged

Conversation

Willmish
Copy link
Collaborator

Pull Request

Issue Number: #383

Summary

Replace current method of removing dangling images to do so only if there are any (and avoid running docker rmi -f with no params).

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #383

@Willmish Willmish force-pushed the fix_azure_function_workflow branch from 8246b60 to 3c7864d Compare September 12, 2023 09:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #393 (d1cb14c) into dev (b3b3189) will increase coverage by 0.72%.
Report is 16 commits behind head on dev.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #393      +/-   ##
==========================================
+ Coverage   74.21%   74.93%   +0.72%     
==========================================
  Files          77       77              
  Lines        2637     2637              
  Branches      266      265       -1     
==========================================
+ Hits         1957     1976      +19     
+ Misses        598      580      -18     
+ Partials       82       81       -1     
Files Changed Coverage Δ
...re.WebApi/src/Controllers/CarbonAwareController.cs 93.82% <ø> (ø)
...s.ElectricityMaps/src/ElectricityMapsDataSource.cs 65.04% <50.00%> (+0.97%) ⬆️
...arbonAware.WebApi/src/Models/CarbonIntensityDTO.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Willmish Willmish force-pushed the fix_azure_function_workflow branch from 3c7864d to d1cb14c Compare September 12, 2023 09:09
@Willmish Willmish requested a review from danuw September 12, 2023 09:11
@Willmish
Copy link
Collaborator Author

@danuw now fixed :)

Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - thanks

@danuw danuw merged commit cfd76fe into Green-Software-Foundation:dev Sep 19, 2023
@Willmish Willmish deleted the fix_azure_function_workflow branch September 19, 2023 08:13
@danuw danuw added the v1.2 label Dec 12, 2023
@danuw danuw added this to the Release 1.2 milestone Dec 12, 2023
@YaSuenag YaSuenag mentioned this pull request Dec 12, 2023
6 tasks
@danuw danuw mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: container_azure_function job in GHA failed
3 participants