Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST - DO NOT APPROVE #418

Closed
wants to merge 18 commits into from
Closed

TEST - DO NOT APPROVE #418

wants to merge 18 commits into from

Conversation

Willmish
Copy link
Collaborator

@Willmish Willmish commented Nov 21, 2023

Pull Request (PR)

something else

copilot:description

Summary (summary)

copilot:summary

Changes (walkthrough)

copilot:walkthrough

copilot:poem

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #<issue_number>

in4margaret and others added 18 commits March 4, 2023 16:34
Fix missing FromQuery params
Fix integration tests not using JSON datasource mocker
I, Margaret <[email protected]>, hereby add my Signed-off-by to this commit: f881406
I, Margaret <[email protected]>, hereby add my Signed-off-by to this commit: f343cab

Signed-off-by: Margaret <[email protected]>
Signed-off-by: Yasumasa Suenaga <[email protected]>
* cleaning workflows

Signed-off-by: Dan Benitah <[email protected]>

* pull request should on trigger for pull request event - removing on push for PRs

Signed-off-by: Dan Benitah <[email protected]>

* syntax

Signed-off-by: Dan Benitah <[email protected]>

* syntax

Signed-off-by: Dan Benitah <[email protected]>

* moving markdown linting and disabling 2.a-deploy

Signed-off-by: Dan Benitah <[email protected]>

* adding some jobs dependencies so packaging does not run if code does not build etc...

Signed-off-by: Dan Benitah <[email protected]>

* moving code analysis into the build step and clean up

Signed-off-by: Dan Benitah <[email protected]>

---------

Signed-off-by: Dan Benitah <[email protected]>
Co-authored-by: danuw <[email protected]>
* Skip deploy workflows in forked repos

Signed-off-by: Yasumasa Suenaga <[email protected]>

* Add vars

Signed-off-by: Yasumasa Suenaga <[email protected]>

---------

Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Roman Lutz <[email protected]>
Issue : 

I have tested a ElectricityMaps forecast scenario CLI: 
"emissions-forecasts -l westeurope -v"
will return server error 500.

Analysis:

public async Task<EmissionsForecast> GetCurrentCarbonIntensityForecastAsync(Location location) is causing the EM server to return 500. Reason is that the "." in geolocation.Latitude will be passed as "," 

Fix:

The following changes are fixing this bug.

Signed-off-by: Christian Binder <[email protected]>
fixing 3 broken links in overview.md

Signed-off-by: nttDamien <[email protected]>
Integration tests coverage for WebAPI and CLI
Signed-off-by: Roman Lutz <[email protected]>
Fix: verify-azure-function-with-packages #383
…receives request for forecast

Signed-off-by: Yasumasa Suenaga <[email protected]>
EMFree data source should regard specified time range
@codecov-commenter
Copy link

Codecov Report

Merging #418 (ff355f3) into main (ad44005) will increase coverage by 0.46%.
Report is 4 commits behind head on main.
The diff coverage is 15.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   74.21%   74.67%   +0.46%     
==========================================
  Files          77       77              
  Lines        2637     2646       +9     
  Branches      266      268       +2     
==========================================
+ Hits         1957     1976      +19     
+ Misses        598      589       -9     
+ Partials       82       81       -1     
Files Coverage Δ
...re.WebApi/src/Controllers/CarbonAwareController.cs 93.82% <ø> (ø)
...arbonAware.WebApi/src/Models/CarbonIntensityDTO.cs 100.00% <100.00%> (ø)
...s.ElectricityMaps/src/ElectricityMapsDataSource.cs 65.04% <50.00%> (+0.97%) ⬆️
...icityMapsFree/src/ElectricityMapsFreeDataSource.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants