-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor demangle.hpp
header from Boost
#1816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
msimberg
commented
Feb 14, 2025
havogt
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I am currently adding back a CSCS CI, then we can merge.
cscs-ci run |
1 similar comment
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the
demangle.hpp
header from Boost (https://github.com/boostorg/core/blob/787b03ea9ca35089cecb80c5f2ca37e10046fbaf/include/boost/core/demangle.hpp) and moves it into thegridtools
namespace.I've done this conversion manually, since it's only one header and it hasn't changed in the last 9 years in Boost. The dependency on
boost/config.hpp
in the original version is only forBOOST_HAS_PRAGMA_ONCE
(replaced to use#pragma once
unconditionally),BOOST_GCC
(check for__GNUC__
directly) andBOOST_NOEXCEPT
(usenoexcept
unconditionally).This is part one of two for removing boost as a dependency. The second part to remove Boost.Preprocessor is #1817.