feat[next]: Allow using compile time connectivity information only #1862
+55
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Feb 14, 2025
| @@ -123,16 +126,19 @@ def translate( | |||
| ] | |||
| horizontal_sizes: dict[str, itir.Expr] | |||
| if symbolic_domain_sizes is not None: | |||
| horizontal_sizes = {k: im.ref(v) for k, v in symbolic_domain_sizes.items()} | |||
| horizontal_sizes = { | |||
There was a problem hiding this comment.
Strictly unrelated to the actual PR. This just allows using literals as the symbolic domain sizes. Needed for a hack in icon4py. Didn't bother creating a PR.
havogt
requested changes
Feb 26, 2025
| @@ -43,7 +43,7 @@ def __call__( | |||
| def apply_common_transforms( | |||
| ir: itir.Program, | |||
| *, | |||
| offset_provider=None, # TODO(havogt): should be replaced by offset_provider_type, but global_tmps currently relies on runtime info | |||
| offset_provider: common.OffsetProvider | common.OffsetProviderType, | |||
There was a problem hiding this comment.
I disagree with removing the TODO.
There was a problem hiding this comment.
Re-added with minor changes.
havogt
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain inference relies on either runtime connectivities or compile time information on the size of the domains (
symbolic_domain_sizes), whereas the later is used in icon4py, in particular the blue line, where runtime information is not available. The approach taken in this PR is to allow passing either ancommon.OffsetProvideror ancommon.OffsetProviderType.