ci: read python versions from files #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
force-pushed
the
explicit-python-versions
branch
from
e38f4fb to
477ddef
Compare
|
cscs-ci run |
| @@ -120,7 +119,7 @@ def test_examples(session: nox.Session) -> None: | |||
| ("examples", (None)), | |||
| ]: | |||
| session.run( | |||
| *f"pytest --nbmake {notebook} -sv -n {num_processes}".split(), | |||
| *f"pytest --nbmake {notebook} -sv -n 1 --benchmark-disable".split(), | |||
There was a problem hiding this comment.
Is this change related to your comment about disabling the notebook tests?
There was a problem hiding this comment.
Yes, although my comment is about disabling the parallel execution of the notebook tests, not about disabling the tests.
|
LGTM |
havogt
approved these changes
Mar 20, 2025
| @@ -9,18 +9,31 @@ on: | |||
| - functional | |||
|
|
|||
| jobs: | |||
| # First job to read Python versions from .python-versions file | |||
There was a problem hiding this comment.
This is probably the only hint that it is AI generated...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode in files the python versions used for testing, linting and other CI and development tasks.
.default-python-versioncontains the python version used by default for development tasks (previously.python-versionwas used, but it conflicted with other tools like pyenv)..python-versionscontains all supported python versions. This file is read byuvto set up the development environment. To avoid conflicts, the first version in the file should match the content ofdefault-python-version. This file is also used by a new github action which is used by all CI jobs where the python version is a factor of the strategy matrix.Additionally, the nox task running the example notebooks is not longer executed in parallel. This change is unrelated to this PR, but it seems necessary to have stable results on CI.