Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake_minimum_required #85

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

lukasm91
Copy link
Contributor

cmake_minimum_required is outdated because of https://github.com/lukasm91/gtbench/blob/master/CMakeLists.txt#L60

This was added in CMake 3.24: https://cmake.org/cmake/help/latest/module/FetchContent.html

The error with CMake 3.22 is absolutely useless:

CMake Error at /gtbench/_deps/gridtools-subbuild/gridtools-populate-prefix/tmp/gridtools-populate-gitupdate.cmake:25 (message):
  Failed to get the hash for HEAD:

@lukasm91 lukasm91 requested a review from fthaler August 12, 2024 14:25
@fthaler fthaler merged commit 28fee50 into GridTools:master Aug 12, 2024
2 checks passed
@lukasm91 lukasm91 deleted the fix-cmake-version branch August 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants