Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository 구조 변경 #138

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Repository 구조 변경 #138

wants to merge 15 commits into from

Conversation

wonu606
Copy link
Contributor

@wonu606 wonu606 commented Jan 10, 2024

스크린샷 2024-01-10 오후 5 55 59

그림과 같이 구조 변경

하면서 느낀 점

  • 이전 구조에서 가끔씩 누락된 JPA 커스텀 메서드들이 있었다.
    커스텀 메서드가 누락되는 것을 알기 힘들기에 이전 구조는 위험한 것 같다.

@wonu606 wonu606 requested review from onetuks and byeolhaha January 10, 2024 19:17
@wonu606 wonu606 changed the base branch from main_ to develop January 10, 2024 19:18
Copy link
Contributor

@onetuks onetuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어지러운 구조가 정리되니까 훨씬 보기 좋네요!!

고생하셨습니다

Has a 관계를 생각하지 않고 instance of 만 생각했던게 지난 구조의 패착이었나보네요

병합충돌 있어서 일단 리뷰만 남겼습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants