Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyfakefs to support Python 3.12 #172

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Bump pyfakefs to support Python 3.12 #172

merged 2 commits into from
Dec 20, 2023

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Dec 19, 2023

Older pyfakefs fails with:

    flavour = pathlib._Flavour  # type: ignore [attr-defined]
              ^^^^^^^^^^^^^^^^
AttributeError: module 'pathlib' has no attribute '_Flavour'

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 19, 2023

poke @ojii

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 19, 2023

I can't merge this PR until GHA completes and GHA won't run until maintainer approves running the workflow on the PR 🙇🏻

@y26805
Copy link
Contributor

y26805 commented Dec 19, 2023

I can't merge this PR until GHA completes and GHA won't run until maintainer approves running the workflow on the PR 🙇🏻

approved the run! looks mergeable now 🙏

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 20, 2023

let me fix typing complaints and hopefully it will be all good.

P.S.

Only those with write access to this repository can merge pull requests.

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 20, 2023

@y26805 please consider allowing GHA again 🙇🏻 and maybe merge it if all checks pass, because I'm not allowed to 🙇🏻

@y26805
Copy link
Contributor

y26805 commented Dec 20, 2023

looks like all tests passed, will merge this. thanks @dimaqq 🙏

@y26805 y26805 merged commit 468e887 into HENNGE:master Dec 20, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants