Separate request and response logging into other named loggers. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on this? |
I'd like to make the logging for aiodynamo louder at times for debugging or to generally see in application logs when a throttle or a timeout or something happened. For that, I need to set the log level to debug, but this also enables request and response payload logging which becomes very noisy and also smears potentially unwanted data into my log streams. I made two other loggers so the levels for those two things can be set at a different level to all the other logging done by aiodynamo.
aclemons
force-pushed
the
payload-names-loggers
branch
from
138bcad to
5628360
Compare
|
👉🏻 @ojii |
ojii
approved these changes
Jul 13, 2024
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make the logging for aiodynamo louder at times for debugging
or to generally see in application logs when a throttle or a timeout or
something happened. For that, I need to set the log level to debug, but
this also enables request and response payload logging which becomes
very noisy and also smears potentially unwanted data into my log
streams.
I made two other loggers so the levels for those two things can be
set at a different level to all the other logging done by aiodynamo.