Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a type mismatch for TransactionCanceled #184

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix a type mismatch for TransactionCanceled #184

merged 2 commits into from
Jun 17, 2024

Conversation

aisk
Copy link
Contributor

@aisk aisk commented May 29, 2024

The cancellation_reasons have a mismatched type when initializing, and this change fixes it. Additionally, it has been changed to use Optional instead of Union[T, None] because they are equivalent but Optional has a shorter name.

ojii
ojii approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ojii ojii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@y26805 y26805 merged commit ca86d46 into HENNGE:master Jun 17, 2024
33 checks passed
@aisk aisk deleted the fix-error-type branch June 17, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojii ojii ojii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aisk @ojii @y26805