Upgrade Terraform modules in examples

HENNGE · Nov 6, 2023 · 8ade034 · 8ade034
1 parent 38b5fd2
commit 8ade034
Show file tree

Hide file tree

Showing 13 changed files with 51 additions and 60 deletions.
diff --git a/examples/complete-ecs/README.md b/examples/complete-ecs/README.md
@@ -38,15 +38,15 @@ $ terraform apply
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_alb"></a> [alb](#module\_alb) | terraform-aws-modules/alb/aws | 5.13.0 |
 | <a name="module_alb_security_group"></a> [alb\_security\_group](#module\_alb\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
-| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 3.0 |
+| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 7.0 |
 | <a name="module_asg_autoscaling"></a> [asg\_autoscaling](#module\_asg\_autoscaling) | ../../modules/autoscaling/asg-target-tracking/ecs-reservation | n/a |
 | <a name="module_easy_ec2"></a> [easy\_ec2](#module\_easy\_ec2) | ../../modules/simple/ec2 | n/a |
 | <a name="module_easy_fargate"></a> [easy\_fargate](#module\_easy\_fargate) | ../../modules/simple/fargate | n/a |
@@ -56,7 +56,7 @@ $ terraform apply
 | <a name="module_ecs_security_group"></a> [ecs\_security\_group](#module\_ecs\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
 | <a name="module_fargate_service_autoscaling_target"></a> [fargate\_service\_autoscaling\_target](#module\_fargate\_service\_autoscaling\_target) | ../../modules/core/ecs-autoscaling-target | n/a |
 | <a name="module_fargate_target_request_autoscaling"></a> [fargate\_target\_request\_autoscaling](#module\_fargate\_target\_request\_autoscaling) | ../../modules/autoscaling/alb-target-tracking/target-requests-count | n/a |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/complete-ecs/autoscaling.tf b/examples/complete-ecs/autoscaling.tf
@@ -3,7 +3,7 @@ module "asg_autoscaling" {
   source = "../../modules/autoscaling/asg-target-tracking/ecs-reservation"
 
   name                   = "${local.prefix}-autoscale"
-  autoscaling_group_name = module.asg.this_autoscaling_group_name
+  autoscaling_group_name = module.asg.autoscaling_group_id
   ecs_cluster_name       = module.ecs_cluster.name
 
   enable_cpu_based_autoscaling = true

diff --git a/examples/complete-ecs/support_infra.tf b/examples/complete-ecs/support_infra.tf
@@ -4,7 +4,7 @@ data "aws_ssm_parameter" "ami_image" {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -17,7 +17,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = var.enable_ipv6
-  assign_ipv6_address_on_creation               = var.enable_ipv6
   public_subnet_assign_ipv6_address_on_creation = var.enable_ipv6
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }
@@ -127,21 +126,20 @@ resource "aws_lb_listener_rule" "fargate" {
 
 module "asg" {
   source  = "terraform-aws-modules/autoscaling/aws"
-  version = "~> 3.0"
+  version = "~> 7.0"
 
   name = "${local.prefix}-asg"
 
-  image_id                    = data.aws_ssm_parameter.ami_image.value
-  instance_type               = "t2.micro"
-  security_groups             = [module.ecs_security_group.security_group_id]
-  vpc_zone_identifier         = module.vpc.public_subnets
-  min_size                    = 1
-  max_size                    = 10
-  desired_capacity            = 1
-  health_check_type           = "EC2"
-  associate_public_ip_address = true
+  image_id            = data.aws_ssm_parameter.ami_image.value
+  instance_type       = "t2.micro"
+  security_groups     = [module.ecs_security_group.security_group_id]
+  vpc_zone_identifier = module.vpc.public_subnets
+  min_size            = 1
+  max_size            = 10
+  desired_capacity    = 1
+  health_check_type   = "EC2"
   user_data = templatefile("../templates/ec2_userdata.tpl", {
     ecs_cluster = module.ecs_cluster.name
   })
-  iam_instance_profile = var.instance_profile_arn
+  iam_instance_profile_arn = var.instance_profile_arn
 }
diff --git a/examples/easy/ec2-alb/README.md b/examples/easy/ec2-alb/README.md
@@ -31,19 +31,19 @@ To test that it's working:
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_alb"></a> [alb](#module\_alb) | terraform-aws-modules/alb/aws | 5.13.0 |
 | <a name="module_alb_security_group"></a> [alb\_security\_group](#module\_alb\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
-| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 3.0 |
+| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 7.0 |
 | <a name="module_easy_ec2"></a> [easy\_ec2](#module\_easy\_ec2) | ../../../modules/simple/ec2 | n/a |
 | <a name="module_ec2_security_group"></a> [ec2\_security\_group](#module\_ec2\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
 | <a name="module_ecs_cluster"></a> [ecs\_cluster](#module\_ecs\_cluster) | ../../.. | n/a |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/easy/ec2-alb/main.tf b/examples/easy/ec2-alb/main.tf
@@ -16,7 +16,7 @@ locals {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -29,7 +29,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = var.enable_ipv6
-  assign_ipv6_address_on_creation               = var.enable_ipv6
   public_subnet_assign_ipv6_address_on_creation = var.enable_ipv6
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }
@@ -107,23 +106,22 @@ module "alb" {
 
 module "asg" {
   source  = "terraform-aws-modules/autoscaling/aws"
-  version = "~> 3.0"
+  version = "~> 7.0"
 
   name = "${local.prefix}-asg"
 
-  image_id                    = data.aws_ssm_parameter.ami_image.value
-  instance_type               = "t2.micro"
-  security_groups             = [module.ec2_security_group.security_group_id]
-  vpc_zone_identifier         = module.vpc.public_subnets
-  min_size                    = 1
-  max_size                    = 2
-  desired_capacity            = 1
-  health_check_type           = "EC2"
-  associate_public_ip_address = true
+  image_id            = data.aws_ssm_parameter.ami_image.value
+  instance_type       = "t2.micro"
+  security_groups     = [module.ec2_security_group.security_group_id]
+  vpc_zone_identifier = module.vpc.public_subnets
+  min_size            = 1
+  max_size            = 2
+  desired_capacity    = 1
+  health_check_type   = "EC2"
   user_data = templatefile("../../templates/ec2_userdata.tpl", {
     ecs_cluster = module.ecs_cluster.name
   })
-  iam_instance_profile = var.instance_profile_arn
+  iam_instance_profile_arn = var.instance_profile_arn
 }
 
 # This module usage starts here

diff --git a/examples/easy/ec2/README.md b/examples/easy/ec2/README.md
@@ -37,17 +37,17 @@ $ terraform apply
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 4.0 |
+| <a name="module_asg"></a> [asg](#module\_asg) | terraform-aws-modules/autoscaling/aws | ~> 7.0 |
 | <a name="module_easy_ec2"></a> [easy\_ec2](#module\_easy\_ec2) | ../../../modules/simple/ec2 | n/a |
 | <a name="module_ec2_security_group"></a> [ec2\_security\_group](#module\_ec2\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
 | <a name="module_ecs_cluster"></a> [ecs\_cluster](#module\_ecs\_cluster) | ../../.. | n/a |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/easy/ec2/main.tf b/examples/easy/ec2/main.tf
@@ -16,7 +16,7 @@ locals {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -29,7 +29,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = var.enable_ipv6
-  assign_ipv6_address_on_creation               = var.enable_ipv6
   public_subnet_assign_ipv6_address_on_creation = var.enable_ipv6
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }
@@ -55,19 +54,18 @@ module "ec2_security_group" {
 
 module "asg" {
   source  = "terraform-aws-modules/autoscaling/aws"
-  version = "~> 4.0"
+  version = "~> 7.0"
 
   name = "${local.prefix}-asg"
 
-  image_id                    = data.aws_ssm_parameter.ami_image.value
-  instance_type               = "t2.micro"
-  security_groups             = [module.ec2_security_group.security_group_id]
-  vpc_zone_identifier         = module.vpc.public_subnets
-  min_size                    = 1
-  max_size                    = 2
-  desired_capacity            = 1
-  health_check_type           = "EC2"
-  associate_public_ip_address = true
+  image_id            = data.aws_ssm_parameter.ami_image.value
+  instance_type       = "t2.micro"
+  security_groups     = [module.ec2_security_group.security_group_id]
+  vpc_zone_identifier = module.vpc.public_subnets
+  min_size            = 1
+  max_size            = 2
+  desired_capacity    = 1
+  health_check_type   = "EC2"
   user_data = templatefile("../../templates/ec2_userdata.tpl", {
     ecs_cluster = module.ecs_cluster.name
   })

diff --git a/examples/easy/fargate-alb/README.md b/examples/easy/fargate-alb/README.md
@@ -38,7 +38,7 @@ $ terraform apply
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
@@ -49,7 +49,7 @@ $ terraform apply
 | <a name="module_easy_fargate"></a> [easy\_fargate](#module\_easy\_fargate) | ../../../modules/simple/fargate | n/a |
 | <a name="module_ecs_cluster"></a> [ecs\_cluster](#module\_ecs\_cluster) | ../../.. | n/a |
 | <a name="module_task_security_group"></a> [task\_security\_group](#module\_task\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/easy/fargate-alb/main.tf b/examples/easy/fargate-alb/main.tf
@@ -12,7 +12,7 @@ locals {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -25,7 +25,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = var.enable_ipv6
-  assign_ipv6_address_on_creation               = var.enable_ipv6
   public_subnet_assign_ipv6_address_on_creation = var.enable_ipv6
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }

diff --git a/examples/easy/fargate-spot/README.md b/examples/easy/fargate-spot/README.md
@@ -43,7 +43,7 @@ $ terraform apply
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
@@ -52,7 +52,7 @@ $ terraform apply
 | <a name="module_easy_fargate"></a> [easy\_fargate](#module\_easy\_fargate) | ../../../modules/simple/fargate-spot | n/a |
 | <a name="module_ecs_cluster"></a> [ecs\_cluster](#module\_ecs\_cluster) | ../../.. | n/a |
 | <a name="module_task_security_group"></a> [task\_security\_group](#module\_task\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/easy/fargate-spot/main.tf b/examples/easy/fargate-spot/main.tf
@@ -11,7 +11,7 @@ locals {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -24,7 +24,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = true
-  assign_ipv6_address_on_creation               = true
   public_subnet_assign_ipv6_address_on_creation = true
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }

diff --git a/examples/easy/fargate/README.md b/examples/easy/fargate/README.md
@@ -36,7 +36,7 @@ $ terraform apply
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.74.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.24.0 |
 
 ## Modules
 
@@ -45,7 +45,7 @@ $ terraform apply
 | <a name="module_easy_fargate"></a> [easy\_fargate](#module\_easy\_fargate) | ../../../modules/simple/fargate | n/a |
 | <a name="module_ecs_cluster"></a> [ecs\_cluster](#module\_ecs\_cluster) | ../../.. | n/a |
 | <a name="module_task_security_group"></a> [task\_security\_group](#module\_task\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
-| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 2.0 |
+| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | ~> 5.0 |
 
 ## Resources
 

diff --git a/examples/easy/fargate/main.tf b/examples/easy/fargate/main.tf
@@ -11,7 +11,7 @@ locals {
 
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
-  version = "~> 2.0"
+  version = "~> 5.0"
 
   name = "${local.prefix}-vpc"
   cidr = local.vpc_cidr
@@ -24,7 +24,6 @@ module "vpc" {
   dhcp_options_domain_name_servers = ["AmazonProvidedDNS"]
 
   enable_ipv6                                   = true
-  assign_ipv6_address_on_creation               = true
   public_subnet_assign_ipv6_address_on_creation = true
   public_subnet_ipv6_prefixes                   = range(length(local.vpc_azs))
 }