-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support execute command configuration in ECS cluster config #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once all checks are successful.
Validation failed because |
Personally it's fine to increase to 0.14, @michaelaw320 ? |
I think it's fine to update minimum supported version to 0.14 |
@michaelaw320 Do we need to bump major version? |
yes, let's bump it major |
b6fe21e
to
350a99d
Compare
|
350a99d
to
38b5fd2
Compare
Avoided |
What required the bump to 1.0? |
The upgraded module in examples requires Terraform 1.0. Considering 1.0 has been around for 2 years I think it's time to bump the version too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work 💪
@michaelaw320 Any objection to merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please merge and create new release
No description provided.