Expose placement constraints on easy EC2 module #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanscg
approved these changes
Jan 12, 2024
FurqanHabibi
approved these changes
Jan 12, 2024
|
Just realized that the service placement_constraints is linked to task definition's which might fail if the service defines 'distinctInstance' option as according to terraform docs, 'distinctInstance' is not supported in task definition, will open another PR to separate service vs task definition placement_constraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose placement constraints on easy EC2 module
I noticed that the task definition itself in core is quite outdated, need to update to latest terraform's also need more test to figure out minimum version that the new updated task definition needs