Fix aws_appautoscaling_target default tags tf plan pollution

[FurqanHabibi]

As explained in this issue: hashicorp/terraform-provider-aws#31261,
old aws_appautoscaling_target (created before 2023-03-20) can not have any tags or default tags,
otherwise it will perpetually show up in tf plan.

This implement a workaround by ignoring tags_all that may have been set in the provider default tags.

[hanscg]

Does this also ignore tags_all for the newer resource?
The newer resource does support default tags, doesn't it?

[FurqanHabibi]

Does this also ignore tags_all for the newer resource?
The newer resource does support default tags, doesn't it?

Yes it does.
Although I would think this is still okay for aws_appautoscaling_target since we cannot even interact with them from AWS console (only through aws-cli), so adding tags is not as necessary.

Since this is a workaround, we can get back to it once the issue is fixed in the provider side 🙏

[hanscg]

Since we're trying to use tag-based access control in IAM roles, I think it will complicates things if we can't modify the default tag for the resource.

I think it's better to leave it be and recreate the autoscaling target to resolve the default tag problem.

[FurqanHabibi]

Closed in favor of recreating aws_appautoscaling_target to allow adding tags.