Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit for modules #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raoashish10
Copy link

@raoashish10 raoashish10 commented Jan 25, 2021

I am opening this PR because I need feedback and what should be the steps to follow ahead. At the moment, it is incomplete. I fetched the readthedocs embed api and I am displaying it in the modules menu and I have given each module a section. I understand that it doesn't look that great but the problem is when I am embedding the HTML, I am not able to edit any of it and thus, it looks a little weird. I can change the sphinx documentation to suit these new docs but that might disrupt the readthedocs documentation that had been hosted earlier. Any ideas as to how I can make changes to the HTML? Feedback would be appreciated @priyanshunayan .

Also each page has been fetched in different files using the API. I can change that if the loading times are different and if that creates a discrepancy. I just thought having different components for each section would be better as I would be able to include fragmentation in the page

@raoashish10
Copy link
Author

raoashish10 commented Jan 25, 2021

I believe the checks have failed because I have added 2 new dependencies: DOMPurify and node-fetch

@priyanshunayan
Copy link
Member

priyanshunayan commented Jan 27, 2021

Hi @raoashish10!

For now, I have pushed with changes in this PR which demonstrate that we can style the dangerously set innerHTML in the divs. The content objects return with some standard ids and classes which can be styled using scoped CSS. Also, feel free to use states as well. And please let me know If you face any problem.

See, I styled all links to red(Eh!), but I hope I am able to give a working example.
image

@raoashish10
Copy link
Author

@priyanshunayan Thank you for this! This was quite helpful I will work on it and I will let you know if there are any further doubts

@raoashish10
Copy link
Author

https://deploy-preview-9--hydra-docs.netlify.app/src-content-modules-hydra-python-core

I tried editing the code snippet in the "How to use" section of hydra-python-core but I couldn't change the text to monospace for some reason. It was gets cancelled and is overided by the default text set in global.css.
Please let me know the changes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants