Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser in accordance with changes made at hydra-python-core #19

Open
1 of 2 tasks
vddesai1871 opened this issue Aug 2, 2019 · 5 comments
Open
1 of 2 tasks

Comments

@vddesai1871
Copy link

I'm submitting a

  • bug report.
  • feature request.

Current Behaviour:

The current parser uses old Hydra terms which are replaced since long, as we have updated hydra-python-core with developments made at Hydra-CG spec, outdated parser will create a HydraDoc incompatible with hydra-python-core and hydrus.

Expected Behaviour:

The parser should be updated with respect to changes made at hydra-python-core and thus on parsing it should create a HydraDoc compatible with latest Hydra Spec.

Steps to reproduce:

Do you want to work on this issue?

YES

@vddesai1871 vddesai1871 changed the title Update in accordance with changes made at hydra-python-core Update parser in accordance with changes made at hydra-python-core Aug 2, 2019
@roufiq
Copy link

roufiq commented Jan 4, 2021

no follow up?

@chrizandr
Copy link
Member

A lot of changes in both hydra-spec and the openapi spec have been made since this project was last updated. This issue is only regarding updates with hydra-python-core, but the broader issue of updating in accordance to the spec needs to be done before this issue can be taken up.

@farazkhanfk7
Copy link
Member

If no one is working on it I would like to take this one.

@amalthundiyil
Copy link
Contributor

@chrizandr Would it be acceptable to resolve this issue by fixing the parser at its current state first and then addressing the "broader issue" by creating a separate issue?

@farazkhanfk7
Copy link
Member

farazkhanfk7 commented Dec 12, 2021

@amal-thundiyil The current version of hydra-openapi-parser is outdated. It uses old Hydra terms which are
no longer in use. Also, hydra-python-core has gone through lots of developments since the
last time parser was updated, as a result it throws error and returns an incompatible
HydraDoc. Many functions in hydra-openapi-parser are missing parameters. The parser should be
updated according to the changes in hydra-python-core and Hydra Specs.
And yes, you can create a separate issue for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants