Development of the Hydra OpenAPI Parser - v2 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this! |
Mec-iS
requested review from
Mec-iS,
chrizandr,
farazkhanfk7,
priyanshunayan,
Purvanshsingh,
sameshl and
xadahiya
- Separated concerns by adding `/parsers` and `/processors` - Parsers are responsible for parsing the text of the OpenAPI Spec and extracting relevant information for creating a `HydraDoc` - Processors then use this information and act as an adapter to the `hydra-python-core` which then convert it to a Hydra Object - These Hydra objects are then used by the `APIClassProcessor` to finally create a relevant Hydra Class and then send it to the `OpenAPIDocParser` which assimilates everything to create a `HydraDoc`
amalthundiyil
force-pushed
the
parser_v2
branch
from
fc8e5b7 to
6478d56
Compare
Mec-iS
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
/parsersand/processorsParsersare responsible for parsing the text of the OpenAPI Spec and extracting relevant information for creating a Hydra ObjectProcessorsthen use this information and act as an adapter to thehydra-python-corewhich then convert it to a Hydra ObjectAPIClassProcessorto finally create a relevant Hydra Class along with the other relevant "metadata" using theAPIInfoProcessorand then sending it to theOpenAPIDocParserwhich assimilates everything to create aHydraDocThis PR addresses a lot of the open issues in this project currently (#21 , #4 , #19) and is inspired by the Swagger Parser heavily.
Future improvements:
hydra-python-coreSchemaObjects and JSON pointers.