Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to requirements.txt and README #11

Merged
merged 7 commits into from
Feb 24, 2019
Merged

Add to requirements.txt and README #11

merged 7 commits into from
Feb 24, 2019

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Feb 24, 2019

Fixes #5 and #10

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

This is to further continue the work done in #9 by completing the process of moving the parser out of the hydrus repo.

Change logs

Update README and add to requirements.txt

Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work @de-sh

Copy link

@vddesai1871 vddesai1871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

setup.py Outdated Show resolved Hide resolved
@de-sh
Copy link
Contributor Author

de-sh commented Feb 24, 2019

Guys, shouldn't we be following the same structure in the setup.py file as in the other repos?

Also, when I used BFG-repo-cleaner to delete a file from history, all the older commit hashes also changed, and that is why they show up here. Anyways, only changes made, can be viewed here.

@de-sh de-sh changed the title Refactor Add to requirements.txt and README Feb 24, 2019
@Mec-iS Mec-iS merged commit 5a86a95 into HTTP-APIs:develop Feb 24, 2019
@de-sh de-sh deleted the refactor branch February 24, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants