Ran all python code through black, code formater #16
Conversation
| @@ -103,7 +107,7 @@ def valid_endpoint(path: str) -> str: | |||
| :return: | |||
| """ | |||
| # "collection" or true means valid | |||
| path_ = path.split('/') | |||
| path_ = path.split("/") | |||
There was a problem hiding this comment.
you should be sure that the rules for the formatter stick to the conventions we established for the codebase. For example: we decide to always use ' single quotes for strings, except that for dictionaries meant to be dumped into JSON strings and for variables added via f-strings like f'Some text with a {dict["variable"]}'
In general you have to stick to how is done in hydrus.
There was a problem hiding this comment.
| @@ -103,7 +107,7 @@ def valid_endpoint(path: str) -> str: | |||
| :return: | |||
| """ | |||
| # "collection" or true means valid | |||
| path_ = path.split('/') | |||
| path_ = path.split("/") | |||
There was a problem hiding this comment.
| }, | ||
| { | ||
| "@type": "SupportedProperty", | ||
| "property": "", | ||
| "readonly": "true", | ||
| "required": "false", | ||
| "title": "category", | ||
| "writeonly": "true" | ||
| "writeonly": "true", |
There was a problem hiding this comment.
I don't see the point of adding all these commas.
Please stick to pep8 package as a reference libary
|
See my review. We cannot really change the styling library every time, we have always been using pep8 package as far as I remember |
Ok, These were a suggestion based on the output of black, put it up for review, seems like this is not necessary... comments? The PR can be closed if it seems to be unnecessary 👍 |
|
I agree, we already have PEP8 based code formatting in all other repos. It would make more sense to stick to it than to change the format to something new. I don't potentially see any benefit in switching over to black. EDIT: If you can give some insights as to why you think this is better, we might be open to more discussion about this. Otherwise I will close the PR. |
|
@chrizandr I thought python/black is provided by the PSF and hence using it would be better. There is no other reasoning and I have since come to think of not using a no compromise code formatter. I believe it's better to close this PR |
Fixes un-formatted code with black
Checklist
Description
The Black code formatter library is a python standard for maintaining readable code bases, I have run the code of the parser through it to make it more readable and PEP8 compliant.
Change logs