Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sphinx documentation #163

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

raoashish10
Copy link

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

Added a sphinx documentation for the hydra-python-agent repo as I noticed that it didn't have one. Also the documentation can then be hosted on readthedocs so that it can be embedded into the new documentation. The sphinx documentation was created specially for the automodule feature

Change logs

Added

A docs folder which contains the sphinx documentation.

I am running into some errors while using the agent with the new Movie API doc. So the index page is incomplete because it has certain examples missing which I will add as soon as I fix the erros.

@priyanshunayan
Copy link
Member

Can you let me know what are errors that you are facing while using the agent so that we can fix them?

Copy link
Member

@priyanshunayan priyanshunayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the steps to run the sphinx docs locally can be a good addition in the readme?

@raoashish10
Copy link
Author

@priyanshunayan Sure! I will add the steps. My doubt was that when I am trying to run the put function with the new Apidoc, I am getting an error:
image

Am I missing any steps or am I making any mistake?

@raoashish10
Copy link
Author

@priyanshunayan I managed to fix the error (@farazkhanfk7 helped out) and I have added examples for different types of request with the Movie api doc. Let me know if anything else needs to be changed. I have also added the steps to build the docs locally in a README file.

Copy link
Member

@priyanshunayan priyanshunayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a ✨ work!

I have suggested a few minor changes and we would be good to go!

docs/README.md Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Show resolved Hide resolved
@Mec-iS Mec-iS dismissed priyanshunayan’s stale review March 13, 2021 17:05

this has been changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants