Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Queries for 2024 #3735

Merged
merged 53 commits into from
Nov 9, 2024
Merged

JavaScript Queries for 2024 #3735

merged 53 commits into from
Nov 9, 2024

Conversation

nrllh
Copy link
Collaborator

@nrllh nrllh commented Aug 16, 2024

Makes progress on #3592

@tunetheweb tunetheweb added the analysis Querying the dataset label Aug 21, 2024
@tunetheweb tunetheweb added this to the 2024 Analysis milestone Aug 21, 2024
fixing linter errors
Fixing Linter errors.
Fixing Linter Errors
This just had to be a typo. Where should just be there once.

Linter error.
fixing linter errors
@mgifford
Copy link
Contributor

So the linter wants:
    cast(json_value(summary, '$.firstHtml') AS bool)

to be?
    cast(json_value(summary, '$.firstHtml') AS BOOL)

and 
    SUM(cast(json_value(payload, '$.response.bodySize') AS int64)) / 1024 AS kbytes

to be?
    SUM(cast(json_value(payload, '$.response.bodySize') AS INT64)) / 1024 AS kbytes

I don't know what it wants for:

WHERE
app IN ('jQuery', 'jQuery Migrate', 'jQuery UI', 'Modernizr', 'FancyBox', 'Slick', 'Lightbox', 'Moment.js', 'Underscore.js', 'Lodash', 'React', 'GSAP', 'Vue.js', 'styled-components', 'Emotion', 'Backbone.js', 'RequireJS', 'AngularJS', 'AMP', 'Redux', 'Next.js', 'Stimulus', 'Angular', 'Handlebars', 'Zone.js', 'Marionette.js', 'Mustache', 'Prototype', 'toastr', 'JSS',  'React Router', 'Nuxt.js', 'Alpine.js', 'Svelte', 'MooTools', 'Knockout.js', 'Socket.io', 'Gatsby', 'Adobe Client Data Layer')

@tunetheweb
Copy link
Member

tunetheweb commented Aug 26, 2024

There are two spaces between these two terms: 'JSS', 'React Router' which the linter doesn't like. It (quite rightly!) thinks one space is enough.

You can tell this btw because it's saying the error is on Line 24, position 371 of that file.

== [/github/workspace/sql/2024/javascript/frameworks_libraries_by_version.sql] FAIL
L:  24 | P: 371 | L008 | Expected only single space before quoted literal. Found
                       | '  '.
L:  24 | P: 371 | L039 | Expected only single space before quoted literal. Found
                       | '  '.
L:  24 | P: 371 | L048 | Expected only single space before quoted literal. Found
                       | '  '.
All Finished!

Datatypes must be upper case.
Datatypes must be upper case.
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still uses some of the older tables but let's not hold up up on that.

Let me know if good to merge.

@tunetheweb tunetheweb merged commit ab3e32c into main Nov 9, 2024
3 checks passed
@tunetheweb tunetheweb deleted the javascript-queries-2024 branch November 9, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants