-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searcher Standing Delay #1735
base: main
Are you sure you want to change the base?
Searcher Standing Delay #1735
Conversation
5172c1e
to
30b2792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, only need to fix test cases
17adfbd
to
effb203
Compare
f72ab03
to
de3527d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready to be merged? I recall there was some issue with this?
move functionality of delayed movement of defender that became earcher in searcher make the standing time after role change dynamic depending on last known ball posiiton add senario and fmt rename variable undo change of if condition add new edge detection change ball position in passive_defender_positioning
3627970
to
53d9d62
Compare
Right now it fixes the linked issue and should work. TODO (for next issue?) is to refactor behaviour to only have one last_role variable (and not |
Why? What?
Suppress turning of an searcher for a dynamic time after role assignment.
The time depends on the distance to the last known ball position and is scaled with an parameter to estimate a hypothetical ball velocity in m/s.
Fixes #1395
Ideas for Next Iterations (Not This PR)
None
How to Test
You can see the effects in the
standing_searcher
-scenario.