Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searcher Standing Delay #1735

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

paudar
Copy link
Contributor

@paudar paudar commented Mar 13, 2025

Why? What?

Suppress turning of an searcher for a dynamic time after role assignment.
The time depends on the distance to the last known ball position and is scaled with an parameter to estimate a hypothetical ball velocity in m/s.

Fixes #1395

Ideas for Next Iterations (Not This PR)

None

How to Test

You can see the effects in the standing_searcher-scenario.

@github-project-automation github-project-automation bot moved this to Request for Review in Development Mar 13, 2025
@paudar paudar force-pushed the defender-searcher-delay branch from 5172c1e to 30b2792 Compare March 13, 2025 20:10
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only need to fix test cases

@schmidma schmidma added the GO25 label Mar 14, 2025
@paudar paudar force-pushed the defender-searcher-delay branch 2 times, most recently from 17adfbd to effb203 Compare March 14, 2025 07:47
@schluis schluis moved this from Request for Review to In Progress in Development Mar 15, 2025
@paudar paudar force-pushed the defender-searcher-delay branch 2 times, most recently from f72ab03 to de3527d Compare March 16, 2025 08:26
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to be merged? I recall there was some issue with this?

paudar added 5 commits April 2, 2025 16:55
move functionality of delayed movement of defender that became earcher in searcher

make the standing time after role change dynamic depending on last known ball posiiton

add senario and fmt

rename variable

undo change of if condition

add new edge detection

change ball position in passive_defender_positioning
@paudar paudar force-pushed the defender-searcher-delay branch from 3627970 to 53d9d62 Compare April 2, 2025 14:58
@paudar
Copy link
Contributor Author

paudar commented Apr 2, 2025

Right now it fixes the linked issue and should work.

TODO (for next issue?) is to refactor behaviour to only have one last_role variable (and not previous_role: Role and real_previous_role: Role

@oleflb oleflb removed the GO25 label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Let defenders start searching later
3 participants