Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed socket options that are not allowed to be set on a group. #3089

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Dec 17, 2024

  • SRTO_BINDTODEVICE - fix the doc, it says you cat set it on a group
  • SRTO_CONGESTION
  • SRTO_EVENT - readonly
  • SRTO_GROUPCONNECT
  • SRTO_GROUPTYPE - readonly
  • SRTO_ISN - readonly
  • SRTO_KMSTATE - readonly
  • SRTO_RCVDATA - readonly
  • SRTO_RCVKMSTATE - readonly
  • SRTO_RENDEZVOUS
  • SRTO_SENDER
  • SRTO_SNDDATA - readonly
  • SRTO_SNDKMSTATE - readonly
  • SRTO_STATE - readonly
  • SRTO_TRANSTYPE
  • SRTO_TSBPDMODE
  • SRTO_VERSION - readonly

This PR

Readonly (NOTSUP - INVAL):

  • SRTO_ISN: // read-only
  • SRTO_STATE: // read-only
  • SRTO_EVENT: // read-only
  • SRTO_SNDDATA: // read-only
  • SRTO_RCVDATA: // read-only
  • SRTO_KMSTATE: // read-only
  • SRTO_VERSION: // read-only
  • SRTO_PEERVERSION: // read-only
  • SRTO_SNDKMSTATE:
  • SRTO_RCVKMSTATE:
  • SRTO_GROUPTYPE: // read-only

Socket- or link-specific (NOTSUP - INVAL):

  • SRTO_SENDER: // deprecated (1.2.0 version legacy)
  • SRTO_IPV6ONLY: // link-type specific
  • SRTO_RENDEZVOUS: // socket-only
  • SRTO_BINDTODEVICE: // socket-specific
  • SRTO_GROUPCONNECT: // listener-specific
    LOGC(gmlog.Error, log << "group option setter: this option ("<< int(optName) << ") is socket- or link-specific");
    throw CUDTException(MJ_NOTSUP, MN_INVAL, 0);
  • SRTO_CONGESTION : not allowed
  • SRTO_TRANSTYPE: not allowed
  • SRTO_TSBPDMODE : not allowed now

Work within #3074.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Dec 17, 2024
@maxsharabayko maxsharabayko added this to the v1.5.5 milestone Dec 17, 2024
srtcore/group.cpp Outdated Show resolved Hide resolved
srtcore/group.cpp Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit d69b065 into Haivision:master Feb 18, 2025
11 of 12 checks passed
@maxsharabayko maxsharabayko deleted the hotfix/gopt-setdisabled branch February 18, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants