little code correction

HanashiDev · Oct 17, 2024 · 358995f · 358995f
1 parent e7c6850
commit 358995f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/files/lib/acp/form/FaqCategoryAddForm.class.php b/files/lib/acp/form/FaqCategoryAddForm.class.php
@@ -39,6 +39,8 @@ protected function createForm()
     #[Override]
     protected function finalizeForm()
     {
+        parent::finalizeForm();
+
         $this->form->getDataHandler()->addProcessor(
             new CustomFormDataProcessor(
                 'icon',
@@ -57,7 +59,5 @@ function (IFormDocument $document, array $data, IStorableObject $object) {
                 }
             )
         );
-
-        parent::finalizeForm();
     }
 }
diff --git a/files/lib/acp/form/FaqQuestionAddForm.class.php b/files/lib/acp/form/FaqQuestionAddForm.class.php
@@ -35,11 +35,6 @@ class FaqQuestionAddForm extends AbstractFormBuilderForm
      */
     public $activeMenuItem = 'wcf.acp.menu.link.faq.questions.add';
 
-    /**
-     * @inheritDoc
-     */
-    public $formAction = 'create';
-
     /**
      * @inheritDoc
      */
@@ -191,9 +186,9 @@ protected function createForm()
     }
 
     #[Override]
-    public function buildForm()
+    public function finalizeForm()
     {
-        parent::buildForm();
+        parent::finalizeForm();
 
         $this->form->getDataHandler()->addProcessor(new CustomFormDataProcessor(
             'answer_i18n',

diff --git a/files/lib/acp/form/FaqQuestionEditForm.class.php b/files/lib/acp/form/FaqQuestionEditForm.class.php
@@ -40,18 +40,25 @@ public function readParameters()
             if (!$this->formObject->questionID) {
                 throw new IllegalLinkException();
             }
-            if ($this->formObject->isMultilingual) {
-                $this->isMultilingual = 1;
-
-                $languageItemList = new LanguageItemList();
-                $languageItemList->getConditionBuilder()->add('languageItem = ?', [$this->formObject->answer]);
-                $languageItemList->readObjects();
-                foreach ($languageItemList as $languageItem) {
-                    $this->multiLingualAnswers[$languageItem->languageID] = $languageItem->languageItemValue;
-                }
-            }
         } catch (MappingError) {
             throw new IllegalLinkException();
         }
     }
+
+    #[Override]
+    public function readData()
+    {
+        parent::readData();
+
+        if ($this->formObject->isMultilingual) {
+            $this->isMultilingual = 1;
+
+            $languageItemList = new LanguageItemList();
+            $languageItemList->getConditionBuilder()->add('languageItem = ?', [$this->formObject->answer]);
+            $languageItemList->readObjects();
+            foreach ($languageItemList as $languageItem) {
+                $this->multiLingualAnswers[$languageItem->languageID] = $languageItem->languageItemValue;
+            }
+        }
+    }
 }