-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Single Cell Processing #214
Open
JoshLoecker
wants to merge
181
commits into
develop
Choose a base branch
from
fix/single-cell-processing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a single context can be processed at a time; if more contexts need to be processed, merge xomics should be wrapped in a for loop
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
… fix/single-cell-processing
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 20 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- main/COMO.ipynb: Evaluated as low risk
- main/como/types.py: Evaluated as low risk
- main/como/proteomics/proteomics_preprocess.py: Evaluated as low risk
- main/como/cluster_rnaseq.py: Evaluated as low risk
- main/como/proteomics/FTPManager.py: Evaluated as low risk
- main/como/proteomics_gen.py: Evaluated as low risk
- .github/workflows/continuous_integration.yml: Evaluated as low risk
- ruff.toml: Evaluated as low risk
- main/como/rnaseq_preprocess.py: Evaluated as low risk
- main/como/init.py: Evaluated as low risk
Comments suppressed due to low confidence (6)
main/como/data_types.py:216
- [nitpick] The use of 'SourceTypes.member_map.values()' is unconventional and might be confusing. Consider using 'SourceTypes.members.values()' instead.
if key not in {i.value for i in SourceTypes._member_map_.values()}:
main/como/utils.py:130
- [nitpick] The variable name 'cohersion' might be a typo and should be 'coercion'.
return cohersion
main/como/utils.py:130
- The word 'cohersion' is misspelled; it should be 'coercion'.
return cohersion
main/como/utils.py:88
- The 'entrez_gene_id' column is cast to a string multiple times. This could be optimized.
single_gene_names = expression_data[~expression_data['entrez_gene_id'].astype(str).str.contains('//')]
main/como/utils.py:74
- The new behavior introduced by the 'entrez_as_index' parameter in 'split_gene_expression_data' should be covered by tests.
entrez_as_index: bool = True,
main/como/utils.py:260
- The '_log_and_raise_error' function should ensure that the 'level' parameter is either 'LogLevel.ERROR' or 'LogLevel.CRITICAL'.
case _:
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Signed-off-by: Josh Loecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes errors found when running single-cell RNA sequencing data.
This comment will be updated with a list of breaking changes as they happen
Algorithms
should be imported ascomo.Algorithm
Compartments
should now be imported ascomo.CobraCompartments