Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/Fix] Categories improvements: make them composable, update style, fix combination with filters #3303

Merged
merged 7 commits into from
Dec 10, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 8, 2023

This PR does a few different things related to the new Categories feature:

  • Updated the style to match the new style used in Filters (this depends on that other PR)
  • Made the categories composable, so we can show more than 1 category at a time
  • Added the only action like we have in the filters, so we can easily filter by a single category
  • Replaced the All categories "category" with a more clear Select all button now that they are toggles
  • Fixed an issue when filters like Show hidden or Show Non-Available were ignored if showing a category
  • Save the selected categories when changed and restore on boot (this was partially implemented before but was not working)

One thing that I did NOT implement intentionally is a way to add categories directly from the dropdown, we have to refactor how the categories creation is handled because it currently depends on adding the category for a given game. So to not make this PR bigger, for now I added a message that lets the user know they can add categories using the game menus instead of showing all / uncategorized.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 8, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 8, 2023 20:27
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing stuff, looks a lot better now.
I think the next step (on another Pr though) would be to add a button to add new categories from the categories dropdown, then it will be perfect.

Base automatically changed from filters-only to main December 10, 2023 17:45
@arielj arielj merged commit 408ff9f into main Dec 10, 2023
14 checks passed
@arielj arielj deleted the categories-improvements branch December 10, 2023 18:04
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants